fix(client): raise project-open and directory-suggestion timeouts for large repos by jms830 · Pull Request #1620 · getpaseo/paseo

jms830 · 2026-06-19T19:15:06Z

Linked issue

Type of change

Bug fix

What does this PR do

Opening a project or fetching folder-picker suggestions silently times out on large home directories. The client used a 10s request timeout for both openProject and getDirectorySuggestions, but the daemon's directory scan routinely takes longer on a big ~, so the client gave up before the daemon responded — the picker looked broken even though the daemon was still working.

This raises the client timeouts to match real scan times and debounces the suggestion query so a filesystem scan isn't fired on every keystroke:

daemon-client.ts: openProject 10s -> 60s (it does the most filesystem work); getDirectorySuggestions 10s -> 30s. Inline comments explain each.
project-picker-modal.tsx: 250ms debounce on the directory-suggestions query key.

No protocol or schema changes; client-only timeout/UX tuning.

How did you verify it

Reproduced live against a daemon running on a Linux host with a large home directory, client connected over the LAN.

Before: the folder picker returned nothing / "open" hung. Daemon ws_slow_request logs showed directory_suggestions_request completing on the daemon side but past the 10s client deadline:

durationMs: 6532
durationMs: 8443
durationMs: 10670
durationMs: 11211
durationMs: 17313

After: with the raised timeouts the same scans complete and populate the picker; the 250ms debounce stops a scan firing on every keystroke while typing a path.

Checks: npm run typecheck (app + client) passes, npm run lint 0/0, npm run format clean.

Checklist

One focused change. Unrelated cleanups split out.
npm run typecheck passes
npm run lint passes
npm run format ran (Biome)
UI changes include screenshots or video for every affected platform — N/A: no visual change, this is a timeout/debounce tuning fix (behavior, not appearance)
Tests added or updated where it made sense — covered by existing picker behavior; change is timeout/debounce constants

…arge repos openProject 10s->60s and getDirectorySuggestions 10s->30s + debounce the project-picker query 250ms. On large local repos the daemon's path-resolve and home-tree scan take several seconds; firing per-keystroke against a 10s timeout raced the suggestion list to empty (e.g. ~/gi found a hit but ~/gith blanked) and surfaced a spurious 'Timeout waiting for message (10000ms)' on add.

greptile-apps · 2026-06-19T19:16:52Z

Greptile Summary

This PR addresses silent client-side timeouts when opening large repositories or scanning large home directories for folder-picker autocomplete. It raises the openProject timeout to 60 s and getDirectorySuggestions to 30 s, and adds a 250 ms debounce on the directory-suggestions query key so filesystem scans are not triggered on every keystroke.

daemon-client.ts: openProject timeout raised 10 s → 60 s; getDirectorySuggestions timeout raised 10 s → 30 s, with explanatory inline comments for each.
project-picker-modal.tsx: Introduces debouncedQuery state with a 250 ms useEffect debounce; the queryKey and RPC call now use debouncedQuery while the visible filter (options) still reacts to the immediate query.

Confidence Score: 4/5

Safe to merge; the timeout values are internally consistent and the debounce logic is correct. The PR description has the two timeout numbers swapped relative to what the code actually sets, which could confuse future readers of the commit history.

Both changed files make narrow, targeted edits with no side effects. The debounce is wired correctly — reset on modal close, immediate query still drives the display filter, only the RPC call defers. The one notable issue is that the PR description lists the timeout values in the wrong order compared to the implementation, but the code and inline comments agree with each other.

No files require special attention; the mismatch is documentation-level only.

Important Files Changed

Filename	Overview
packages/client/src/daemon-client.ts	Raises openProject timeout from 10s → 60s and getDirectorySuggestions timeout from 10s → 30s; values are internally consistent with the inline comments but reversed compared to the PR description.
packages/app/src/components/project-picker-modal.tsx	Adds a 250 ms debounce via a new debouncedQuery state so the directory-suggestions RPC fires at most once per pause, not on every keystroke; reset path correctly clears both query and debouncedQuery.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant User
    participant UI as ProjectPickerModal
    participant DQ as debouncedQuery (250ms)
    participant RQ as React Query
    participant DC as DaemonClient
    participant D as Daemon

    User->>UI: types keystroke
    UI->>DQ: setQuery(text)
    Note over DQ: debounce timer resets
    DQ-->>RQ: setDebouncedQuery after 250ms
    RQ->>DC: getDirectorySuggestions(debouncedQuery)
    Note over DC: timeout = 30 000 ms
    DC->>D: directory_suggestions_request
    D-->>DC: directory_suggestions_response
    DC-->>RQ: entries[]
    RQ-->>UI: directorySuggestionsQuery.data

    User->>UI: selects path
    UI->>DC: openProject(path)
    Note over DC: timeout = 60 000 ms
    DC->>D: open_project_request
    D-->>DC: open_project_response
    DC-->>UI: OpenProjectPayload

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant User
    participant UI as ProjectPickerModal
    participant DQ as debouncedQuery (250ms)
    participant RQ as React Query
    participant DC as DaemonClient
    participant D as Daemon

    User->>UI: types keystroke
    UI->>DQ: setQuery(text)
    Note over DQ: debounce timer resets
    DQ-->>RQ: setDebouncedQuery after 250ms
    RQ->>DC: getDirectorySuggestions(debouncedQuery)
    Note over DC: timeout = 30 000 ms
    DC->>D: directory_suggestions_request
    D-->>DC: directory_suggestions_response
    DC-->>RQ: entries[]
    RQ-->>UI: directorySuggestionsQuery.data

    User->>UI: selects path
    UI->>DC: openProject(path)
    Note over DC: timeout = 60 000 ms
    DC->>D: open_project_request
    D-->>DC: open_project_response
    DC-->>UI: OpenProjectPayload

_{Reviews (1): Last reviewed commit: "fix(client): raise project-open & direct..." | Re-trigger Greptile}

greptile-apps · 2026-06-19T19:16:56Z

-      timeout: 10000,
+      // Large local repos (e.g. a big monorepo/brain checkout) need >10s for the
+      // daemon to resolve the path, detect git, and materialize the workspace.
+      timeout: 60000,


PR description has the timeout values swapped

The PR description states "openProject timeout from 10s to 30s" and "getDirectorySuggestions timeout from 10s to 60s", but the implementation does the opposite: openProject is raised to 60 000 ms and getDirectorySuggestions to 30 000 ms. The inline code comments and the logic both support the as-implemented values (opening a project does more work), so the code appears correct, but the PR description is misleading for anyone reviewing the change or reading git history.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

greptile-apps Bot reviewed Jun 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(client): raise project-open and directory-suggestion timeouts for large repos#1620

fix(client): raise project-open and directory-suggestion timeouts for large repos#1620
jms830 wants to merge 1 commit into
getpaseo:mainfrom
jms830:fix/large-repo-timeouts

jms830 commented Jun 19, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Jun 19, 2026

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps Bot Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

jms830 commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linked issue

Type of change

What does this PR do

How did you verify it

Checklist

Uh oh!

greptile-apps Bot commented Jun 19, 2026

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jms830 commented Jun 19, 2026 •

edited

Loading